[PATCH] linux/bits.h: Squash unsigned comparison warning for GENMASK

From: Yazen Ghannam
Date: Tue Feb 04 2025 - 12:13:59 EST


Cast inputs to 'long' to avoid the following 'type-limits' warning:
warning: comparison of unsigned expression in ‘< 0’ is always false

The 'long' type can hold +/- 2G which far exceeds valid inputs for the
GENMASK helpers (current max use is 128 bits).

Idea is similar to implementation in __is_nonneg().

Signed-off-by: Yazen Ghannam <yazen.ghannam@xxxxxxx>
---
Note to maintainers:
I found some previous discussions on this topic in the mailing list
archives. The upstream code has changed a bit since then, and this
proposed solution seems fairly simple when based on the latest code.

I figured I'd look at something outside my normal focus areas. I
apologize for the noise if this solution is too naive or incomplete.

Thanks!
---
include/linux/bits.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/bits.h b/include/linux/bits.h
index 61a75d3f294b..318346f2a5a6 100644
--- a/include/linux/bits.h
+++ b/include/linux/bits.h
@@ -21,7 +21,7 @@
#if !defined(__ASSEMBLY__)
#include <linux/build_bug.h>
#include <linux/compiler.h>
-#define GENMASK_INPUT_CHECK(h, l) BUILD_BUG_ON_ZERO(const_true((l) > (h)))
+#define GENMASK_INPUT_CHECK(h, l) BUILD_BUG_ON_ZERO(const_true((long)(l) > (long)(h)))
#else
/*
* BUILD_BUG_ON_ZERO is not available in h files included from asm files,

---
base-commit: 0de63bb7d91975e73338300a57c54b93d3cc151c
change-id: 20250204-fix-genmask-warn-489a6480779f