Re: [PATCH] powerpc: mpic: Use str_enabled_disabled() helper function

[Ricardo B. Marlière]

On Tue Feb 4, 2025 at 12:44 PM -03, Thorsten Blum wrote:
> Remove hard-coded strings by using the str_enabled_disabled() helper
> function.
>
> Use pr_debug() instead of printk(KERN_DEBUG) to silence a checkpatch
> warning.
>
> Signed-off-by: Thorsten Blum <thorsten.blum@xxxxxxxxx>

Reviewed-by: Ricardo B. Marlière <ricardo@xxxxxxxxxxxx>

> ---
>  arch/powerpc/sysdev/mpic.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/powerpc/sysdev/mpic.c b/arch/powerpc/sysdev/mpic.c
> index d94cf36b0f65..25fc4ac91814 100644
> --- a/arch/powerpc/sysdev/mpic.c
> +++ b/arch/powerpc/sysdev/mpic.c
> @@ -27,6 +27,7 @@
>  #include <linux/spinlock.h>
>  #include <linux/pci.h>
>  #include <linux/slab.h>
> +#include <linux/string_choices.h>
>  #include <linux/syscore_ops.h>
>  #include <linux/ratelimit.h>
>  #include <linux/pgtable.h>
> @@ -474,9 +475,9 @@ static void __init mpic_scan_ht_msi(struct mpic *mpic, u8 __iomem *devbase,
>  		addr = addr | ((u64)readl(base + HT_MSI_ADDR_HI) << 32);
>  	}
>  
> -	printk(KERN_DEBUG "mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> -		PCI_SLOT(devfn), PCI_FUNC(devfn),
> -		flags & HT_MSI_FLAGS_ENABLE ? "enabled" : "disabled", addr);
> +	pr_debug("mpic:   - HT:%02x.%x %s MSI mapping found @ 0x%llx\n",
> +		 PCI_SLOT(devfn), PCI_FUNC(devfn),
> +		 str_enabled_disabled(flags & HT_MSI_FLAGS_ENABLE), addr);
>  
>  	if (!(flags & HT_MSI_FLAGS_ENABLE))
>  		writeb(flags | HT_MSI_FLAGS_ENABLE, base + HT_MSI_FLAGS);