Re: [PATCH v2 1/2] counter: microchip-tcb-capture: Add IRQ handling

From: William Breathitt Gray
Date: Tue Feb 04 2025 - 19:01:01 EST


On Mon, Feb 03, 2025 at 05:29:52PM +0100, Bence Csókás wrote:
> Add interrupt servicing to allow userspace to wait for a trigger event.
>
> Signed-off-by: Bence Csókás <csokas.bence@xxxxxxxxx>

Hi Bence,

Thank you for the patches. When you submit the next revision, please
include a cover letter as that will make it easier for us to separate
high-level discussions about the entire patchset from any individual
patch in particular.

Regarding this particular patch, update the description to mention the
specific types of events supported by this (i.e. Change-of-state and
Overflow events). Even though you expose the capture data in a
subsequent patch, you can push the Capture events in this patch so that
we introduce all the supported interrupt events at once.

Thanks,

William Breathitt Gray

Attachment: signature.asc
Description: PGP signature