RE: [PATCH] HID: intel-thc-hid: Remove deprecated PCI API calls
From: Xu, Even
Date: Tue Feb 04 2025 - 21:21:08 EST
Thanks Bjorn!
Best Regards,
Even Xu
> -----Original Message-----
> From: Bjorn Helgaas <helgaas@xxxxxxxxxx>
> Sent: Tuesday, January 28, 2025 11:58 PM
> To: Philipp Stanner <phasta@xxxxxxxxxx>
> Cc: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Jiri
> Kosina <jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>; Srinivas
> Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>; Mark Pearson <mpearson-
> lenovo@xxxxxxxxx>; linux-input@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-pci@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH] HID: intel-thc-hid: Remove deprecated PCI API calls
>
> On Tue, Jan 28, 2025 at 11:11:57AM +0100, Philipp Stanner wrote:
> > intel-thc-hid reintroduced the already deprecated PCI API functions
> >
> > pcim_iomap_table(),
> > pcim_iomap_regions(),
> > pcim_iounmap_regions(),
> >
> > none of which should be used anymore.
> > ...
>
> > I'm trying to remove this API since a year. Please pay attention to
> > the docstrings in PCI which mark certain functions as deprecated.
>
> If you don't use it already, lei is a great tool that can help watch for things like this:
> https://people.kernel.org/monsieuricon/lore-lei-part-1-getting-started
>
> Or lore queries along this line:
> https://lore.kernel.org/all/?q=rt%3A1.month.ago..+dfb%3Apcim_iomap_table