Re: [PATCH] selftests/mm: Fix thuge-gen test name uniqueness

[Dev Jain]

On 05/02/25 4:23 am, Mark Brown wrote:
> The thuge-gen test_mmap() and test_shmget() tests are repeatedly run for a
> variety of sizes but always report the result of their test with the same
> name, meaning that automated sysetms running the tests are unable to
> distinguish between the various tests. Add the supplied sizes to the logged
> test names to distinguish between runs.
>
> Fixes: b38bd9b2c448 ("selftests/mm: thuge-gen: conform to TAP format output")
> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx>
> ---
>   tools/testing/selftests/mm/thuge-gen.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/mm/thuge-gen.c b/tools/testing/selftests/mm/thuge-gen.c
> index e4370b79b62ffb133056eb843cdd1eaeba6503df..cd5174d735be405220d99ae796a3768f53df6ea4 100644
> --- a/tools/testing/selftests/mm/thuge-gen.c
> +++ b/tools/testing/selftests/mm/thuge-gen.c
> @@ -127,7 +127,7 @@ void test_mmap(unsigned long size, unsigned flags)
>   
>   	show(size);
>   	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s mmap\n", __func__);
> +			 "%s mmap %lu\n", __func__, size);
>   
>   	if (munmap(map, size * NUM_PAGES))
>   		ksft_exit_fail_msg("%s: unmap %s\n", __func__, strerror(errno));
> @@ -165,7 +165,7 @@ void test_shmget(unsigned long size, unsigned flags)
>   
>   	show(size);
>   	ksft_test_result(size == getpagesize() || (before - after) == NUM_PAGES,
> -			 "%s: mmap\n", __func__);
> +			 "%s: mmap %lu\n", __func__, size);
>   	if (shmdt(map))
>   		ksft_exit_fail_msg("%s: shmdt: %s\n", __func__, strerror(errno));
>   }


Suggest converting size to MB before printing. This will print the size 
in bytes which is confusing. Otherwise:

Reviewed-by: Dev Jain <dev.jain@xxxxxxx>