Re: [PATCH 2/2] tty: serial: samsung: add support for exynos7870
From: Krzysztof Kozlowski
Date: Wed Feb 05 2025 - 03:44:14 EST
On Tue, Feb 04, 2025 at 02:08:46AM +0530, Kaustabh Chakraborty wrote:
> Add serial UART support for Exynos7870. The FIFO sizes are not defined
> in the driver, and they must be provided in the devicetree with the
> samsung,uart-fifosize property.
>
> Signed-off-by: Kaustabh Chakraborty <kauschluss@xxxxxxxxxxx>
> ---
> drivers/tty/serial/samsung_tty.c | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c
> index 210fff7164c138e315d20ccaa4a29ce6a7bb2dfe..c8607633fea40df2ec221cfd3653c726094127cb 100644
> --- a/drivers/tty/serial/samsung_tty.c
> +++ b/drivers/tty/serial/samsung_tty.c
> @@ -2493,6 +2493,12 @@ static const struct s3c24xx_serial_drv_data exynos5433_serial_drv_data = {
> .fifosize = { 64, 256, 16, 256 },
> };
>
> +static const struct s3c24xx_serial_drv_data exynos7870_serial_drv_data = {
> + EXYNOS_COMMON_SERIAL_DRV_DATA,
> + /* samsung,uart-fifosize must be specified in the device tree. */
> + .fifosize = { 0 },
> +};
I don't see any difference against Exynos8895, so they look compatible.
Use Exynos8895 as fallback compatible, even though it is a bit reversed.
Best regards,
Krzysztof