Re: [PATCH v1 15/29] cxl/region: Use an endpoint's SPA range to find a region
From: Robert Richter
Date: Wed Feb 05 2025 - 04:01:06 EST
On 17.01.25 15:31:43, Ben Cheatham wrote:
> On 1/7/25 8:10 AM, Robert Richter wrote:
> > static int match_auto_decoder(struct device *dev, void *data)
> > {
> > struct cxl_region_params *p = data;
> > @@ -3214,26 +3249,47 @@ cxl_port_find_switch_decoder(struct cxl_port *port, struct range *hpa)
> > static int cxl_endpoint_initialize(struct cxl_endpoint_decoder *cxled)
> > {
> > struct cxl_memdev *cxlmd = cxled_to_memdev(cxled);
> > - struct cxl_port *iter = cxled_to_port(cxled);
> > - struct range *hpa = &cxled->cxld.hpa_range;
> > + struct cxl_port *parent, *iter = cxled_to_port(cxled);
> > + struct range hpa = cxled->cxld.hpa_range;
> > struct cxl_decoder *cxld = &cxled->cxld;
>
> Can cut down on the dereferencing a bit here by doing:
> struct cxl_decoder *cxld = &cxled->cxld;
> struct range hpa = cxld->hpa_range;
>
> instead.
Changed that, thanks.
-Robert