RE: [PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR transparent mode

[Kandpal, Suraj]

> -----Original Message-----
> From: dri-devel <dri-devel-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Abel
> Vesa
> Sent: Monday, February 3, 2025 4:28 PM
> To: Maarten Lankhorst <maarten.lankhorst@xxxxxxxxxxxxxxx>; Maxime Ripard
> <mripard@xxxxxxxxxx>; Thomas Zimmermann <tzimmermann@xxxxxxx>;
> David Airlie <airlied@xxxxxxxxx>; Simona Vetter <simona@xxxxxxxx>; Karol
> Herbst <kherbst@xxxxxxxxxx>; Lyude Paul <lyude@xxxxxxxxxx>; Danilo
> Krummrich <dakr@xxxxxxxxxx>; Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>;
> Vivi, Rodrigo <rodrigo.vivi@xxxxxxxxx>; Joonas Lahtinen
> <joonas.lahtinen@xxxxxxxxxxxxxxx>; Tvrtko Ursulin <tursulin@xxxxxxxxxxx>;
> Rob Clark <robdclark@xxxxxxxxx>; Abhinav Kumar
> <quic_abhinavk@xxxxxxxxxxx>; Dmitry Baryshkov
> <dmitry.baryshkov@xxxxxxxxxx>; Sean Paul <sean@xxxxxxxxxx>; Marijn
> Suijten <marijn.suijten@xxxxxxxxxxxxxx>
> Cc: Bjorn Andersson <andersson@xxxxxxxxxx>; Konrad Dybcio
> <konradybcio@xxxxxxxxxx>; Johan Hovold <johan@xxxxxxxxxx>; dri-
> devel@xxxxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> nouveau@xxxxxxxxxxxxxxxxxxxxx; intel-gfx@xxxxxxxxxxxxxxxxxxxxx; intel-
> xe@xxxxxxxxxxxxxxxxxxxxx; linux-arm-msm@xxxxxxxxxxxxxxx;
> freedreno@xxxxxxxxxxxxxxxxxxxxx; Abel Vesa <abel.vesa@xxxxxxxxxx>; Deak,
> Imre <imre.deak@xxxxxxxxx>
> Subject: [PATCH v5 3/4] drm/i915/dp: Use the generic helper to control LTTPR
> transparent mode
> 
> LTTPRs operating modes are defined by the DisplayPort standard and the
> generic framework now provides a helper to switch between them, which is
> handling the explicit disabling of non-transparent mode and its
> disable->enable sequence mentioned in the DP Standard v2.0 section
> 3.6.6.1.
> 
> So use the new drm generic helper instead as it makes the code a bit cleaner.
> Since the driver specific implementation holds the lttrp_common_caps, if the
> call to the drm generic helper fails, the lttrp_common_caps need to be
> updated as the helper has already rolled back to transparent mode.
> 
> Acked-by: Imre Deak <imre.deak@xxxxxxxxx>
> Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx>

LGTM,
Reviewed-by: Suraj Kandpal <suraj.kandpal@xxxxxxxxx>

> ---
>  .../gpu/drm/i915/display/intel_dp_link_training.c  | 24 +++++-----------------
>  1 file changed, 5 insertions(+), 19 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> index
> 8b1977cfec503c70f07af716ee2c00e7605c6adf..c5bad311edf7b9a5cebb633b9
> e9692bae397f9ed 100644
> --- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> +++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
> @@ -119,9 +119,6 @@ intel_dp_set_lttpr_transparent_mode(struct intel_dp
> *intel_dp, bool enable)
>  	u8 val = enable ? DP_PHY_REPEATER_MODE_TRANSPARENT :
>  			  DP_PHY_REPEATER_MODE_NON_TRANSPARENT;
> 
> -	if (drm_dp_dpcd_write(&intel_dp->aux, DP_PHY_REPEATER_MODE,
> &val, 1) != 1)
> -		return false;
> -
>  	intel_dp->lttpr_common_caps[DP_PHY_REPEATER_MODE -
> 
> DP_LT_TUNABLE_PHY_REPEATER_FIELD_DATA_STRUCTURE_REV] = val;
> 
> @@ -146,6 +143,7 @@ static bool
> intel_dp_lttpr_transparent_mode_enabled(struct intel_dp *intel_dp)  static
> int intel_dp_init_lttpr_phys(struct intel_dp *intel_dp, const u8
> dpcd[DP_RECEIVER_CAP_SIZE])  {
>  	int lttpr_count;
> +	int ret;
> 
>  	if (!intel_dp_read_lttpr_common_caps(intel_dp, dpcd))
>  		return 0;
> @@ -172,22 +170,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp
> *intel_dp, const u8 dpcd[DP_
>  		return lttpr_count;
>  	}
> 
> -	/*
> -	 * See DP Standard v2.0 3.6.6.1. about the explicit disabling of
> -	 * non-transparent mode and the disable->enable non-transparent
> mode
> -	 * sequence.
> -	 */
> -	intel_dp_set_lttpr_transparent_mode(intel_dp, true);
> -
> -	/*
> -	 * In case of unsupported number of LTTPRs or failing to switch to
> -	 * non-transparent mode fall-back to transparent link training mode,
> -	 * still taking into account any LTTPR common lane- rate/count limits.
> -	 */
> -	if (lttpr_count < 0)
> -		goto out_reset_lttpr_count;
> -
> -	if (!intel_dp_set_lttpr_transparent_mode(intel_dp, false)) {
> +	ret = drm_dp_lttpr_init(&intel_dp->aux, lttpr_count);
> +	if (ret) {
>  		lt_dbg(intel_dp, DP_PHY_DPRX,
>  		       "Switching to LTTPR non-transparent LT mode failed, fall-
> back to transparent mode\n");
> 
> @@ -196,6 +180,8 @@ static int intel_dp_init_lttpr_phys(struct intel_dp
> *intel_dp, const u8 dpcd[DP_
>  		goto out_reset_lttpr_count;
>  	}
> 
> +	intel_dp_set_lttpr_transparent_mode(intel_dp, false);
> +
>  	return lttpr_count;
> 
>  out_reset_lttpr_count:
> 
> --
> 2.34.1