Re: [PATCH v1 17/29] cxl/region: Rename function to cxl_find_decoder_early()

From: Robert Richter
Date: Wed Feb 05 2025 - 06:05:12 EST


On 07.01.25 17:06:04, Gregory Price wrote:
> On Tue, Jan 07, 2025 at 03:10:03PM +0100, Robert Richter wrote:
> > Current function cxl_region_find_decoder() is used to find a port's
> > decoder during region setup. The decoder is later used to attach the
> > port to a region.
> >
> > Rename function to cxl_find_decoder_early() to emphasize its use only
> > during region setup in the early setup stage. Once a port is attached
> > to a region, the region reference can be used to lookup a region's
> > port and decoder configuration (see struct cxl_region_ref).
> >
>
> May want to add a comment preceding the function to record this in the
> code along with the changelog.
>
> > Signed-off-by: Robert Richter <rrichter@xxxxxxx>
>
> Reviewed-by: Gregory Price <gourry@xxxxxxxxxx>

I added a comment. Thanks,

-Robert