Re: [PATCH V2] kthread: Fix build warning variable 'ret' set but not used

From: Frederic Weisbecker
Date: Wed Feb 05 2025 - 06:09:14 EST


Le Wed, Feb 05, 2025 at 11:47:40AM +0530, Dhruva Gole a écrit :
> On Feb 04, 2025 at 20:02:19 +0100, Frederic Weisbecker wrote:
> > Hi Dhruva,
> >
> > Le Tue, Feb 04, 2025 at 09:39:21PM +0530, Dhruva Gole a écrit :
> > > Fix the following build time warning in kthread:
> > >
> > > kernel/kthread.c: In function 'kthread_affine_preferred':
> > > >> kernel/kthread.c:861:13: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
> > > 861 | int ret;
> > > | ^~~
> > >
> > > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > > Closes: https://lore.kernel.org/oe-kbuild-all/202501301528.t0cZVbnq-lkp@xxxxxxxxx/
> > > Signed-off-by: Dhruva Gole <d-gole@xxxxxx>
> >
> > Thanks for your patch but another similar fix was already pending. I have sent
> > the pull request there:
> >
> > https://lore.kernel.org/lkml/Z6JjZMdbDoAX_AVW@xxxxxxxxxxxxx/T/#u
>
> OK, btw another qn I had was does this file not need a MAINTAINERS file
> update?
> I don't see a real MAINTAINER against it, everyone just shows as
> contributors / committers...
> Or is it to be sent to Linus directly?

There is no official maintainer for kthreads. But I volunteer to handle the patches
targeted to it at least for a while given my recent invasive changes there.

Thanks.

>
> --
> Best regards,
> Dhruva Gole
> Texas Instruments Incorporated