Re: [PATCH v5 -next 00/16] sysctl: move sysctls from vm_table into its own files

[Joel Granados]

On Tue, Jan 14, 2025 at 02:50:12PM +0100, Joel Granados wrote:
> On Sat, Jan 11, 2025 at 03:07:35PM +0800, Kaixiong Yu wrote:
> > This patch series moves sysctls of vm_table in kernel/sysctl.c to
> > places where they actually belong, and do some related code clean-ups.
> > After this patch series, all sysctls in vm_table have been moved into its
> > own files, meanwhile, delete vm_table.
> > 
> > All the modifications of this patch series base on
> > linux-next(tags/next-20250110). To test this patch series, the code was
> > compiled with both the CONFIG_SYSCTL enabled and disabled on arm64 and
> > x86_64 architectures. After this patch series is applied, all files
> > under /proc/sys/vm can be read or written normally.
> 
> It is looking good! Here is how I think we should move it upstream:
> 
> 1. These should queued in for 6.15 instead of the next merge window.
>    It is too late in the current cycle and if we put it in now, it will
>    not properly tested in linux-next.
> 
> 2. I am putting this in sysctl-testing with the expectation of pushing this
>    up for the 6.15 merge window. Please tell me if you want this to go
>    through some other tree.
I have rebased on top of 6.14-rc1 and sent it out for sysctl-testing
once more. I'll add it to sysctl-next by the end of the week (unless we
see something pop-up in the testing).

Best

> 
> Thx for the contribution
> 
> Best
> > 
> > my test steps as below listed:
> > 
> > Step 1: Set CONFIG_SYSCTL to 'n' and compile the Linux kernel on the
> > arm64 architecture. The kernel compiles successfully without any errors
> > or warnings.
> > 
> ...
> >  mm/swap.c                          |  16 ++-
> >  mm/swap.h                          |   1 +
> >  mm/util.c                          |  67 +++++++--
> >  mm/vmscan.c                        |  23 +++
> >  mm/vmstat.c                        |  44 +++++-
> >  net/sunrpc/auth.c                  |   2 +-
> >  security/min_addr.c                |  11 ++
> >  23 files changed, 336 insertions(+), 312 deletions(-)
> > 
> > -- 
> > 2.34.1
> > 
> 
> -- 
> 
> Joel Granados

-- 

Joel Granados