Re: [PATCH v2 1/1] checkpatch: strip comments fix

[Miguel Ojeda]

Hi albankurti,

On Wed, Feb 5, 2025 at 1:05 PM albankurti <kurti@xxxxxxxxxx> wrote:
>
> Fixes the false positive warning when there is a comment on a pr_ or
> dev_ log that ends with \n correctly.
> Also contains some improvements on the macro_pattern to make it more
> concise.
>
> Suggested-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1140
> Signed-off-by: albankurti <kurti@xxxxxxxxxx>

Thanks for the patch!

It seems this is v2 of:

    https://lore.kernel.org/rust-for-linux/20250203201149.330117-1-kurti@xxxxxxxxxx/

Is that correct?

If so, the commit title and description looks wrong, i.e. it seems
that you are explaining what it changed w.r.t. v2, but instead you
should put that in a changelog after the `---` line after the
Signed-off-by tag. The commit message and title should describe what
the commit does, just like v1 does.

Also, the kernel requires a "known identity" for signatures. For
instance, the name you use to sign documents in real life. Please let
us know if that is a problem -- see:

    https://docs.kernel.org/process/submitting-patches.html#developer-s-certificate-of-origin-1-1

Cheers,
Miguel