Re: [RFC PATCH v10 27/28] media: iris: enable video driver probe of SM8250 SoC

From: Hans Verkuil
Date: Wed Feb 05 2025 - 09:33:22 EST


On 05/02/2025 15:21, Johan Hovold wrote:
> On Wed, Feb 05, 2025 at 02:15:25PM +0100, Hans Verkuil wrote:
>
>> This discussion about probing the driver is holding up the merging of this
>> driver unnecessarily. For now, only support the iris driver for SM8250 SoC
>> if the venus driver is not enabled:
>>
>> #if !IS_REACHABLE(CONFIG_VIDEO_QCOM_VENUS)
>>
>> That should be uncontroversial, and allows us to merge the iris driver.
>
> Sounds good to me, but that should be IS_ENABLED() as otherwise which
> driver ends up binding depends on whether venus is built as a module or
> not.

You are right, good catch.

Regards,

Hans

>
> Johan