Re: [PATCH v3 1/2] drm/bridge: it6505: add support DRM_BRIDGE_OP_HDMI to drm_bridge

[Dmitry Baryshkov]

On Wed, Feb 05, 2025 at 02:41:03PM +0800, Hermes Wu via B4 Relay wrote:
> From: Hermes Wu <Hermes.wu@xxxxxxxxxx>
> 
> Add DRM_BRIDGE_OP_HDMI to bridge.ops and implement necessary callback
> functions.

Wait.... Now I feel really sorry. I stumbled upon HDMI_related bits and
then I thought that it's a HDMI bridge without actually checking the
datasheet. When you have a hammer, everything looks like a nail...
Except that IT6505 is neither a nail nor an HDMI bridge.

I'm really sorry for pushing you into the wrong way of OP_HDMI. However
I still think that DisplayPort bridges should not implement codec
callbacks directly. Let me play with that over the next few days. I
think in the end we should be able to use .hdmi_audio_*() callbacks
and drm_hdmi_audio_helper.c while not (over)using the OP_HDMI. I'll ping
you in the next few days.

> The native AVI and AUDIO infoframe configuration API are removed.
> 
> In .atomic_enable use
> drm_atomic_helper_connector_hdmi_update_infoframes().
> for infoframe updates.
> 
> Signed-off-by: Hermes Wu <Hermes.wu@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/bridge/ite-it6505.c | 185 ++++++++++++++++++++++--------------
>  1 file changed, 115 insertions(+), 70 deletions(-)
> 
-- 
With best wishes
Dmitry