Re: [PATCH v8 3/3] PCI: amd-mdb: Add AMD MDB Root Port driver

From: Markus Elfring
Date: Wed Feb 05 2025 - 10:16:33 EST



> +++ b/drivers/pci/controller/dwc/pcie-amd-mdb.c
> @@ -0,0 +1,476 @@

> +static void amd_mdb_mask_intx_irq(struct irq_data *data)
> +{

> + raw_spin_lock_irqsave(&port->lock, flags);
> + val = pcie_read(pcie, AMD_MDB_TLP_IR_MASK_MISC);
> + pcie_write(pcie, (val & (~mask)), AMD_MDB_TLP_IR_ENABLE_MISC);
> + raw_spin_unlock_irqrestore(&port->lock, flags);
> +}


Under which circumstances would you become interested to apply a statement
like “guard(raw_spinlock_irqsave)(&port->lock);”?
https://elixir.bootlin.com/linux/v6.13.1/source/include/linux/spinlock.h#L551

Regards,
Markus