Re: [PATCH net-next v4 27/27] dt-bindings: net: pse-pd: ti,tps23881: Add interrupt description

[Krzysztof Kozlowski]

On 05/02/2025 15:18, Kory Maincent wrote:
>>> Add an interrupt property to the device tree bindings for the TI TPS23881
>>> PSE controller. The interrupt is primarily used to detect classification
>>> and disconnection events, which are essential for managing the PSE
>>> controller in compliance with the PoE standard.
>>>  
>>> @@ -62,6 +65,7 @@ unevaluatedProperties: false
>>>  required:
>>>    - compatible
>>>    - reg
>>> +  - interrupts  
>>
>> Why? That's an ABI change. Commit msg mentions something like "essential
>> for standard" so are you saying nothing here was working according to
>> standard before?
> 
> Yes indeed, the disconnection management did not follow the standard. Without
> this series, the power on the ports of this controller is not shut down after a
> Powered Device disconnection. Unfortunately, I did not noticed this before.

This would be useful part of commit msg.

Best regards,
Krzysztof