Re: [PATCH net-next v2 1/2] net: phy: Add support for driver-specific next update time

[Andrew Lunn]

> +	if (phy_polling_mode(phydev) && phy_is_started(phydev)) {
> +		unsigned int next_update_time =
> +			phy_get_next_update_time(phydev);
> +
> +		phy_queue_state_machine(phydev,
> +					msecs_to_jiffies(next_update_time));

Ah, i missed the msecs_to_jiffies() call. But the driver change now
looks wrong. I think to keep things simple, the API should use
jiffies, since that is what phy_queue_state_machine() and
mod_delayed_work() expect.

Did you test with Timer frequency = 100, that should make errors more
obvious.

	Andrew