Re: [PATCH 04/12] cpufreq/amd-pstate: Remove the redundant des_perf clamping in adjust_perf

[Mario Limonciello]

On 2/5/2025 05:25, Dhananjay Ugwekar wrote:
> des_perf is later on clamped between min_perf and max_perf in
> amd_pstate_update. So, remove the redundant clamping from
> amd_pstate_adjust_perf.
>
> Signed-off-by: Dhananjay Ugwekar <dhananjay.ugwekar@xxxxxxx>

Reviewed-by: Mario Limonciello <mario.limonciello@xxxxxxx>

I'll queue this for 6.15.

> ---
>   drivers/cpufreq/amd-pstate.c | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/amd-pstate.c b/drivers/cpufreq/amd-pstate.c
> index a23fb78a442b..2926f292be7b 100644
> --- a/drivers/cpufreq/amd-pstate.c
> +++ b/drivers/cpufreq/amd-pstate.c
> @@ -703,8 +703,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
>   	if (max_perf < min_perf)
>   		max_perf = min_perf;
>   
> -	des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf);
> -
>   	amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true,
>   			policy->governor->flags);
>   	cpufreq_cpu_put(policy);