Re: [PATCH net-next] net: renesas: rswitch: cleanup max_speed setting
From: Andrew Lunn
Date: Wed Feb 05 2025 - 16:28:38 EST
On Wed, Feb 05, 2025 at 09:26:10PM +0100, Nikita Yushchenko wrote:
> > If the interface mode is 5GBASER why set the speed to SPEED_2500?
> > Also, USXGMII allows up to 10G. So this all looks a bit odd.
>
> 2500 is hardware limit (or at least the datasheet states so).
Then it should return -EINVAL if the device tree has a phy-mode the
hardware does not support.
USXGMII is maybe a bit harder, since i don't know if the higher speeds
are optional, but my understanding is that USXGMII allows up to
10G. Is it really using USXGMII, or 2500BaseX?
Andrew