Re: [PATCH net-next v6 4/7] stmmac: intel: configure SerDes according to the interface mode

[Choong Yong Liang]

On 4/2/2025 8:08 pm, Russell King (Oracle) wrote:
> On Tue, Feb 04, 2025 at 02:10:17PM +0800, Choong Yong Liang wrote:
> > +	int (*config_serdes)(struct net_device *ndev,
> > +			     void *priv,
> > +			     phy_interface_t interface);
>
> Since you call this from phylink's mac_finish() method, I would much
> rather the call down into platform code was also called the same so
> we don't end up with a proliferation of methods called from that
> function. As such, please also arrange for it to pass the AN mode as
> well.
>
> Thanks.

Hi Russell,

Thank you for your feedback on the patch. Based on your suggestion, I have 
updated the code to align with the mac_finish() method and included the AN 
mode as well. The updated function signature is as follows:

int (*mac_finish)(struct net_device *ndev,
                  void *priv,
                  unsigned int mode,
                  phy_interface_t interface);

Could you please confirm if this meets your expectations, or if there are 
any further adjustments needed?