Re: [PATCH net-next v4 1/8] net: gro: decouple GRO from the NAPI layer
From: Jakub Kicinski
Date: Wed Feb 05 2025 - 21:56:55 EST
On Wed, 5 Feb 2025 18:48:50 +0100 Eric Dumazet wrote:
> > + struct_group_tagged(gro_node, gro,
> > + unsigned long bitmask;
> > + struct gro_list hash[GRO_HASH_BUCKETS];
> > + struct list_head rx_list; /* Pending GRO_NORMAL skbs */
> > + int rx_count; /* length of rx_list */
> > + u32 napi_id; /* protected by netdev_lock */
> > +
>
> I am old school, I would prefer a proper/standalone old C construct.
+1, fwiw, I thought it was just me..