Re: [PATCH v3 1/8] scsi: ufs: core: Pass target_freq to clk_scale_notify() vop

[Ziqi Chen]

Hi Bean,

Thanks for your review ~

-Ziqi

On 2/3/2025 5:37 PM, Bean Huo wrote:
> On Mon, 2025-02-03 at 16:11 +0800, Ziqi Chen wrote:
> > From: Can Guo <quic_cang@xxxxxxxxxxx>
> >
> > Instead of only two frequencies, if OPP V2 is used, the UFS devfreq
> > clock
> > scaling may scale the clock among multiple frequencies, so just
> > passing
> > up/down to vop clk_scale_notify() is not enough to cover the
> > intermediate
> > clock freqs between the min and max freqs. Hence pass the target_freq
> > ,
> > which will be used in successive commits, to clk_scale_notify() to
> > allow
> > the vop to perform corresponding configurations with regard to the
> > clock
> > freqs.
> >
> > Signed-off-by: Can Guo <quic_cang@xxxxxxxxxxx>
> > Co-developed-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
> > Signed-off-by: Ziqi Chen <quic_ziqichen@xxxxxxxxxxx>
>
> I have reviewed patches [1/8], [2/8], [3/8], [4/8] in the v2, since you
> just changed coding types, and typos , but no logic change in v3. Add
> my review tag agaion:
>
> Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>