Re: [PATCH net-next v4] netdev-genl: Elide napi_id when not present
From: Eric Dumazet
Date: Thu Feb 06 2025 - 04:03:22 EST
On Wed, Feb 5, 2025 at 8:38 PM Joe Damato <jdamato@xxxxxxxxxx> wrote:
>
> There are at least two cases where napi_id may not present and the
> napi_id should be elided:
>
> 1. Queues could be created, but napi_enable may not have been called
> yet. In this case, there may be a NAPI but it may not have an ID and
> output of a napi_id should be elided.
>
> 2. TX-only NAPIs currently do not have NAPI IDs. If a TX queue happens
> to be linked with a TX-only NAPI, elide the NAPI ID from the netlink
> output as a NAPI ID of 0 is not useful for users.
>
> Signed-off-by: Joe Damato <jdamato@xxxxxxxxxx>
Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>