Re: [PATCH] pinctrl: pinconf-generic: Print unsigned value if a format is registered

From: Linus Walleij
Date: Thu Feb 06 2025 - 04:15:24 EST


On Wed, Feb 5, 2025 at 11:11 AM Claudiu <claudiu.beznea@xxxxxxxxx> wrote:

> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
> Commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
> unconditionally switched to printing hex values in
> pinconf_generic_dump_one(). However, if a dump format is registered for the
> dumped pin, the hex value is printed as well. This hex value does not
> necessarily correspond 1:1 with the hardware register value (as noted by
> commit 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")). As a
> result, user-facing output may include information like:
> output drive strength (0x100 uA).
>
> To address this, check if a dump format is registered for the dumped
> property, and print the unsigned value instead when applicable.
>
> Fixes: 3ba11e684d16 ("pinctrl: pinconf-generic: print hex value")
> Signed-off-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>

Patch applied!

Yours,
Linus Walleij