Re: [PATCH v2 2/2] KVM: SVM: Limit AVIC physical max index based on configured max_vcpu_ids

[Naveen N Rao]

Hi Vasant,

On Wed, Feb 05, 2025 at 12:18:29PM +0530, Vasant Hegde wrote:
> Hi Naveen,
> 
> 
> On 2/3/2025 12:07 PM, Naveen N Rao (AMD) wrote:

<snip>

> >  void avic_vm_destroy(struct kvm *kvm)
> >  {
> >  	unsigned long flags;
> > @@ -185,7 +202,8 @@ void avic_vm_destroy(struct kvm *kvm)
> >  	if (kvm_svm->avic_logical_id_table_page)
> >  		__free_page(kvm_svm->avic_logical_id_table_page);
> >  	if (kvm_svm->avic_physical_id_table_page)
> > -		__free_page(kvm_svm->avic_physical_id_table_page);
> > +		__free_pages(kvm_svm->avic_physical_id_table_page,
> > +			     avic_get_physical_id_table_order(kvm));
> 
> Move this hunk to previous patch (1/2) ?
> 
> Rest looks good.

Sure, thanks for the review!


- Naveen