Re: [PATCH v3][next] tty: tty_buffer: Avoid hundreds of -Wflex-array-member-not-at-end warnings

From: Gustavo A. R. Silva
Date: Thu Feb 06 2025 - 04:23:45 EST




@@ -576,11 +579,14 @@ int tty_insert_flip_string_and_push_buffer(struct tty_port *port,
  void tty_buffer_init(struct tty_port *port)
  {
      struct tty_bufhead *buf = &port->buf;
+    struct tty_buffer *buf_sentinel;
+
+    buf_sentinel = container_of(&buf->sentinel, struct tty_buffer, hdr);

Bah, so this is ugly and even dangerous if someone adds a member to tty_buffer outside _hdr.

Precisely. :) This is one (more) of the reasons why of the struct_group()/static_assert()
proposed changes.

-Gustavo