Re: [PATCH] serial: mctrl_gpio: Remove unused mctrl_gpio_free

[Linus Walleij]

On Wed, Jan 29, 2025 at 3:00 AM <linux@xxxxxxxxxxx> wrote:

> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> mctrl_gpio_free() was added in 2014 by
> commit 84130aace839 ("tty/serial: Add GPIOLIB helpers for controlling
> modem lines")
>
> It does have a comment saying:
>   '- * Normally, this function will not be called, as the GPIOs will
>    - * be disposed of by the resource management code.'
>
> indeed, it doesn't seem to have been used since it was added.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@xxxxxxxxxxx>

Looks correct.
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij