Re: [PATCH v5 1/5] exit: perform add_device_randomness() without tasklist_lock
From: Christian Brauner
Date: Thu Feb 06 2025 - 05:41:14 EST
On Wed, Feb 05, 2025 at 09:56:56PM +0100, Oleg Nesterov wrote:
> On 02/05, Mateusz Guzik wrote:
> >
> > Parallel calls to add_device_randomness() contend on their own.
> ...
> > + add_device_randomness(&p->se.sum_exec_runtime,
> > + sizeof(p->se.sum_exec_runtime));
>
> OK, but
>
> > + free_pids(post.pids);
>
> wait... free_pids() comes later in 4/5 ?
Yes, that seems to be an accidental leftover. A
git rebase -S -i v6.14-rc1 -x "make -j7 O=build.v1/ kernel/"
caught this right away. Removed.