Re: [v3 2/2] pwm: atcpit100: add Andes PWM driver support

From: Uwe Kleine-König
Date: Thu Feb 06 2025 - 06:46:04 EST


Hello Ben,

On Thu, Feb 06, 2025 at 04:08:58PM +0800, Ben Zong-You Xie wrote:
> Also, I will remove "depends on RISCV" [...]

Krzysztof didn't say so explicitly, but I think he wanted the dependency
to be more restrictive, not less. At least that would be my concern
here.

The rational is: Don't annoy people who work on ARM or x86 with
questions about this driver that they don't need anyhow. If there is no
stricter dependency possible, I'm happy with

depends on RISCV || COMPILE_TEST

. If however your driver is implemented in an FPGA, adding a dependency
on a set of SoCs that have the known FPGA that provides that device
would be a good idea.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature