[RFT][PATCH v1 3/5] cpuidle: menu: Tweak threshold use in get_typical_interval()

From: Rafael J. Wysocki
Date: Thu Feb 06 2025 - 09:32:14 EST


From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>

To prepare get_typical_interval() for subsequent changes, rearrange
the use of the data point threshold in it a bit and initialize that
threshold to UINT_MAX which is more consistent with its data type.

No intentional functional impact.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx>
---
drivers/cpuidle/governors/menu.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/cpuidle/governors/menu.c
+++ b/drivers/cpuidle/governors/menu.c
@@ -116,7 +116,7 @@
*/
static unsigned int get_typical_interval(struct menu_device *data)
{
- unsigned int max, divisor, thresh = INT_MAX;
+ unsigned int max, divisor, thresh = UINT_MAX;
u64 avg, variance, avg_sq;
int i;

@@ -129,8 +129,8 @@
for (i = 0; i < INTERVALS; i++) {
unsigned int value = data->intervals[i];

- /* Discard data points above the threshold. */
- if (value > thresh)
+ /* Discard data points above or at the threshold. */
+ if (value >= thresh)
continue;

divisor++;
@@ -186,7 +186,7 @@
if ((divisor * 4) <= INTERVALS * 3)
return UINT_MAX;

- thresh = max - 1;
+ thresh = max;
goto again;
}