Re: [PATCH][next] ext4: avoid dozens of -Wflex-array-member-not-at-end warnings

[Theodore Ts'o]

On Tue, Nov 19, 2024 at 04:37:05PM -0600, Gustavo A. R. Silva wrote:
> -Wflex-array-member-not-at-end was introduced in GCC-14, and we
> are getting ready to enable it, globally.
> 
> Use the `DEFINE_RAW_FLEX()` helper for an on-stack definition of
> a flexible structure (`struct shash_desc`) where the size of the
> flexible-array member (`__ctx`) is known at compile-time, and
> refactor the rest of the code, accordingly.
> 
> So, with these changes, fix 38 of the following warnings:
> 
> fs/ext4/ext4.h:2471:35: warning: structure containing a flexible array member is not at the end of another structure [-Wflex-array-member-not-at-end]
> 
> Signed-off-by: Gustavo A. R. Silva <gustavoars@xxxxxxxxxx>

Thanks, for this patch!  It appears that this patch has since been
obviated by Eric Bigger's commit f2b4fa19647e (" ext4: switch to using
the crc32c library"), which landed during this merge window, so this
patch should not be needed.

						- Ted