Re: [PATCH v2 5/8] ASoC: SOF: imx8: drop unneeded/unused macros/header includes

[Frank Li]

On Wed, Feb 05, 2025 at 03:30:19PM -0500, Laurentiu Mihalcea wrote:
> From: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx>
>
> Drop some unneeded/unused macro definitions and header includes.
>
> Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@xxxxxxx>
> Reviewed-by: Daniel Baluta <daniel.baluta@xxxxxxx>
> Reviewed-by: Iuliana Prodan <iuliana.prodan@xxxxxxx>

Reviewed-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  sound/soc/sof/imx/imx8.c | 29 -----------------------------
>  1 file changed, 29 deletions(-)
>
> diff --git a/sound/soc/sof/imx/imx8.c b/sound/soc/sof/imx/imx8.c
> index 5d6524d695e2..5ce094943aa2 100644
> --- a/sound/soc/sof/imx/imx8.c
> +++ b/sound/soc/sof/imx/imx8.c
> @@ -6,41 +6,12 @@
>  //
>  // Hardware interface for audio DSP on i.MX8
>
> -#include <linux/firmware.h>
> -#include <linux/of_platform.h>
> -#include <linux/of_address.h>
> -#include <linux/of_irq.h>
> -#include <linux/pm_domain.h>
> -
> -#include <linux/module.h>
> -#include <sound/sof.h>
> -#include <sound/sof/xtensa.h>
> -#include <linux/firmware/imx/ipc.h>
> -#include <linux/firmware/imx/dsp.h>
> -
>  #include <linux/firmware/imx/svc/misc.h>
>  #include <dt-bindings/firmware/imx/rsrc.h>
> -#include "../ops.h"
> -#include "../sof-of-dev.h"
>  #include "imx-common.h"
>
> -/* DSP memories */
> -#define IRAM_OFFSET		0x10000
> -#define IRAM_SIZE		(2 * 1024)
> -#define DRAM0_OFFSET		0x0
> -#define DRAM0_SIZE		(32 * 1024)
> -#define DRAM1_OFFSET		0x8000
> -#define DRAM1_SIZE		(32 * 1024)
> -#define SYSRAM_OFFSET		0x18000
> -#define SYSRAM_SIZE		(256 * 1024)
> -#define SYSROM_OFFSET		0x58000
> -#define SYSROM_SIZE		(192 * 1024)
> -
>  #define RESET_VECTOR_VADDR	0x596f8000
>
> -#define MBOX_OFFSET	0x800000
> -#define MBOX_SIZE	0x1000
> -
>  static struct snd_soc_dai_driver imx8_dai[] = {
>  	IMX_SOF_DAI_DRV_ENTRY_BIDIR("esai0", 1, 8),
>  	IMX_SOF_DAI_DRV_ENTRY_BIDIR("sai1", 1, 32),
> --
> 2.34.1
>