Re: [PATCH v17 1/1] mctp pcc: Implement MCTP over PCC Transport

[Adam Young]

Is that your only concern with this patch?  I think as the MCTP 
maintainer, your opinion is going to weigh heavily on whether this gets 
merged or not.  I am more than willing to spin up a new version of this 
but want to avoid unnecessary churn.

What else would need to happen in order for this to get ACKed at this point?


On 2/6/25 02:04, Jeremy Kerr wrote:
> Hi Adam,
>
> One minor note below if you end up re-rolling for other reasons, but
> regardless of that:
>
> Acked-by: Jeremy Kerr <jk@xxxxxxxxxxxxxxxxxxxx>
>
> > +       /* ndev needs to be freed before the iomemory (mapped above) gets
> > +        * unmapped,  devm resources get freed in reverse to the order they
> > +        * are added.
> > +        */
> > +       rc = mctp_register_netdev(ndev, &mctp_netdev_ops, MCTP_PHYS_BINDING_PCC);
> > +       if (rc)
> > +               goto cleanup_netdev;
> > +       return  devm_add_action_or_reset(dev, mctp_cleanup_netdev, ndev);
> You seem to have a trigger-happy spacebar; there is another double-space
> creeping in here, after the 'return'.
>
> Cheers,
>
>
> Jeremy