Re: [PATCH] x86: rust: set rustc-abi=x86-softfloat on rustc>=1.86.0
From: Miguel Ojeda
Date: Thu Feb 06 2025 - 13:56:08 EST
On Mon, Feb 3, 2025 at 9:41 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> When using Rust on the x86 architecture, we are currently using the
> unstable target.json feature to specify the compilation target. Rustc is
> going to change how softfloat is specified in the target.json file on
> x86, thus update generate_rust_target.rs to specify softfloat using the
> new option.
>
> Note that if you enable this parameter with a compiler that does not
> recognize it, then that triggers a warning but it does not break the
> build.
>
> Cc: stable@xxxxxxxxxxxxxxx # for 6.12.y
> Link: https://github.com/rust-lang/rust/pull/136146
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
x86: I will pick this up, but if x86 wants to do so, that would be
welcome -- in which case:
Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
and I would recommend updating the Cc stable tag to mention 6.13 and
the reason to avoid over-backports, e.g.
Cc: <stable@xxxxxxxxxxxxxxx> # Needed in 6.12.y and 6.13.y only
(Rust is pinned in older LTSs).
Cheers,
Miguel