Re: [PATCH 1/3] compiler.h: Move C string helpers into C-only kernel section

From: Kees Cook
Date: Thu Feb 06 2025 - 16:28:30 EST


On Thu, Feb 06, 2025 at 09:07:05PM +0100, Miguel Ojeda wrote:
> On Thu, Feb 6, 2025 at 7:11 PM Kees Cook <kees@xxxxxxxxxx> wrote:
> >
> > The C kernel helpers for evaluating C Strings were placed outside of the
> > assembly ifdef. Move them to the correct place so future changes won't
> > confuse the assembler.
>
> This moves it also into the kernel ifdef too -- I assume that is
> intentional. (Perhaps mention ifndef instead of ifdef?)

Right, yeah. I guess I only mentioned that in the Subject. I'll clarify.

>
> I checked that this is indeed a pure move, so:
>
> Reviewed-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Thanks!

-Kees

--
Kees Cook