Re: [PATCH] x86: rust: set rustc-abi=x86-softfloat on rustc>=1.86.0
From: Miguel Ojeda
Date: Thu Feb 06 2025 - 18:13:16 EST
On Mon, Feb 3, 2025 at 9:41 AM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> When using Rust on the x86 architecture, we are currently using the
> unstable target.json feature to specify the compilation target. Rustc is
> going to change how softfloat is specified in the target.json file on
> x86, thus update generate_rust_target.rs to specify softfloat using the
> new option.
>
> Note that if you enable this parameter with a compiler that does not
> recognize it, then that triggers a warning but it does not break the
> build.
>
> Cc: stable@xxxxxxxxxxxxxxx # for 6.12.y
> Link: https://github.com/rust-lang/rust/pull/136146
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
Applied to `rust-fixes` -- thanks everyone!
[ For future reference, this solves the following error:
RUSTC L rust/core.o
error: Error loading target specification: target feature
`soft-float` is incompatible with the ABI but gets enabled in
target spec. Run `rustc --print target-list` for a list of
built-in targets
- Miguel ]
[ Added 6.13.y too to Cc: stable tag and added reasoning to avoid
over-backporting. - Miguel ]
Cheers,
Miguel