Re: [PATCH net-next v3 1/2] netdev-genl: Add an XSK attribute to queues
From: kernel test robot
Date: Fri Feb 07 2025 - 01:43:58 EST
Hi Joe,
kernel test robot noticed the following build errors:
[auto build test ERROR on c2933b2befe25309f4c5cfbea0ca80909735fd76]
url: https://github.com/intel-lab-lkp/linux/commits/Joe-Damato/netdev-genl-Add-an-XSK-attribute-to-queues/20250205-031236
base: c2933b2befe25309f4c5cfbea0ca80909735fd76
patch link: https://lore.kernel.org/r/20250204191108.161046-2-jdamato%40fastly.com
patch subject: [PATCH net-next v3 1/2] netdev-genl: Add an XSK attribute to queues
config: arm-defconfig (https://download.01.org/0day-ci/archive/20250207/202502071452.B85Lw7aV-lkp@xxxxxxxxx/config)
compiler: clang version 21.0.0git (https://github.com/llvm/llvm-project ee3bccab34f57387bdf33853cdd5f214fef349a2)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250207/202502071452.B85Lw7aV-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502071452.B85Lw7aV-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> net/core/netdev-genl.c:398:12: error: no member named 'pool' in 'struct netdev_rx_queue'
398 | if (rxq->pool) {
| ~~~ ^
>> net/core/netdev-genl.c:410:12: error: no member named 'pool' in 'struct netdev_queue'
410 | if (txq->pool) {
| ~~~ ^
2 errors generated.
vim +398 net/core/netdev-genl.c
366
367 static int
368 netdev_nl_queue_fill_one(struct sk_buff *rsp, struct net_device *netdev,
369 u32 q_idx, u32 q_type, const struct genl_info *info)
370 {
371 struct net_devmem_dmabuf_binding *binding;
372 struct netdev_rx_queue *rxq;
373 struct netdev_queue *txq;
374 struct nlattr *nest;
375 void *hdr;
376
377 hdr = genlmsg_iput(rsp, info);
378 if (!hdr)
379 return -EMSGSIZE;
380
381 if (nla_put_u32(rsp, NETDEV_A_QUEUE_ID, q_idx) ||
382 nla_put_u32(rsp, NETDEV_A_QUEUE_TYPE, q_type) ||
383 nla_put_u32(rsp, NETDEV_A_QUEUE_IFINDEX, netdev->ifindex))
384 goto nla_put_failure;
385
386 switch (q_type) {
387 case NETDEV_QUEUE_TYPE_RX:
388 rxq = __netif_get_rx_queue(netdev, q_idx);
389 if (rxq->napi && nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID,
390 rxq->napi->napi_id))
391 goto nla_put_failure;
392
393 binding = rxq->mp_params.mp_priv;
394 if (binding &&
395 nla_put_u32(rsp, NETDEV_A_QUEUE_DMABUF, binding->id))
396 goto nla_put_failure;
397
> 398 if (rxq->pool) {
399 nest = nla_nest_start(rsp, NETDEV_A_QUEUE_XSK);
400 nla_nest_end(rsp, nest);
401 }
402
403 break;
404 case NETDEV_QUEUE_TYPE_TX:
405 txq = netdev_get_tx_queue(netdev, q_idx);
406 if (txq->napi && nla_put_u32(rsp, NETDEV_A_QUEUE_NAPI_ID,
407 txq->napi->napi_id))
408 goto nla_put_failure;
409
> 410 if (txq->pool) {
411 nest = nla_nest_start(rsp, NETDEV_A_QUEUE_XSK);
412 nla_nest_end(rsp, nest);
413 }
414 }
415
416 genlmsg_end(rsp, hdr);
417
418 return 0;
419
420 nla_put_failure:
421 genlmsg_cancel(rsp, hdr);
422 return -EMSGSIZE;
423 }
424
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki