Re: [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB vdd info

From: Varadarajan Narayanan
Date: Fri Feb 07 2025 - 02:37:23 EST


On Thu, Feb 06, 2025 at 08:40:43PM +0100, Konrad Dybcio wrote:
> On 5.02.2025 8:46 AM, Varadarajan Narayanan wrote:
> > USB phys in ipq9574 use the 'L5' regulator. The commit
> > ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
> > incorrectly specified it as 'L2'. Because of this when the phy
> > module turns off/on its regulators, 'L2' is turned off/on
> > resulting in 2 issues, namely 'L5' is not turned off/on and the
> > network module powered by the 'L2' is turned off/on.
>
> Please wrap your lines at ~72 chars
>
> You use "'L5'" and "'L2'" a lot, making it hard to read. Try focusing
> on the effect.

Have posted the next version addressing this. Please take a look.

Thanks
Varada