Re: [PATCH RFC v2] dt-bindings: mmc: mmc-slot: make compatible property optional

[Dharma.B]

On 06/02/25 11:57 pm, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> 
> ForwardedMessage.eml
> 
> Subject:
> Re: [PATCH RFC v2] dt-bindings: mmc: mmc-slot: make compatible property 
> optional
> From:
> Conor Dooley <conor@xxxxxxxxxx>
> Date:
> 06/02/25, 11:57 pm
> 
> To:
> Dharma Balasubiramani <dharma.b@xxxxxxxxxxxxx>
> CC:
> Ulf Hansson <ulf.hansson@xxxxxxxxxx>, Rob Herring <robh@xxxxxxxxxx>, 
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Conor Dooley 
> <conor+dt@xxxxxxxxxx>, Neil Armstrong <neil.armstrong@xxxxxxxxxx>, Kevin 
> Hilman <khilman@xxxxxxxxxxxx>, Jerome Brunet <jbrunet@xxxxxxxxxxxx>, 
> Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx>, linux- 
> mmc@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-arm- 
> kernel@xxxxxxxxxxxxxxxxxxx, linux-amlogic@xxxxxxxxxxxxxxxxxxx, linux- 
> kernel@xxxxxxxxxxxxxxx
> 
> 
> On Wed, Feb 05, 2025 at 09:18:40AM +0530, Dharma Balasubiramani wrote:
>> Remove the compatible property from the list of required properties and
>> mark it as optional.
>>
>> Signed-off-by: Dharma Balasubiramani<dharma.b@xxxxxxxxxxxxx>
>> ---
>> Changes in v2:
>> - Instead of moving the compatible string to the other binding, just make it
>>    optional (remove from required list).
>> - Link to v1:https://lore.kernel.org/r/20241219-mmc-slot-v1-1- 
>> dfc747a3d3fb@xxxxxxxxxxxxx
> Why is this RFC? I don't see any complaints from Rob's bot, so I am
> assuming that this actually works and the error you mentioned in the
> previously version has been resolved?

yes, it is resolved.

I used the RFC prefix because Neil requested it:
*"Just send a v2 as RFC, so we can comment on it."*

> 
>> ---
>>   Documentation/devicetree/bindings/mmc/mmc-slot.yaml | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> index 1f0667828063..ca3d0114bfc6 100644
>> --- a/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> +++ b/Documentation/devicetree/bindings/mmc/mmc-slot.yaml
>> @@ -29,7 +29,6 @@ properties:
>>       maxItems: 1
>>   
>>   required:
>> -  - compatible
>>     - reg
>>   
>>   unevaluatedProperties: false
>>
>> ---
>> base-commit: 40b8e93e17bff4a4e0cc129e04f9fdf5daa5397e
>> change-id: 20241219-mmc-slot-0574889daea3
>>
>> Best regards,
>> -- 
>> Dharma Balasubiramani<dharma.b@xxxxxxxxxxxxx>
>>


-- 
With Best Regards,
Dharma B.