Re: [PATCH] LoongArch: kernel: proc: Use str_yes_no() helper function

[WangYuli]

Deprecated.

On 2025/2/7 14:52, WangYuli wrote:
> Remove hard-coded strings by using the str_yes_no() helper function.
>
> Similar to commit c4a0a4a45a45 ("MIPS: kernel: proc: Use str_yes_no()
> helper function").
>
> Co-developed-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> Signed-off-by: Wentao Guan <guanwentao@xxxxxxxxxxxxx>
> Signed-off-by: Yuli Wang <wangyuli@xxxxxxxxxxxxx>
> ---
>   arch/loongarch/kernel/proc.c | 7 +++----
>   1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/arch/loongarch/kernel/proc.c b/arch/loongarch/kernel/proc.c
> index 6ce46d92f1f1..56a230238c9c 100644
> --- a/arch/loongarch/kernel/proc.c
> +++ b/arch/loongarch/kernel/proc.c
> @@ -91,10 +91,9 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>   	if (cpu_has_lbt_mips)	seq_printf(m, " lbt_mips");
>   	seq_printf(m, "\n");
>   
> -	seq_printf(m, "Hardware Watchpoint\t: %s",
> -		      cpu_has_watch ? "yes, " : "no\n");
> +	seq_printf(m, "Hardware Watchpoint\t: %s", str_yes_no(cpu_has_watch));
>   	if (cpu_has_watch) {
> -		seq_printf(m, "iwatch count: %d, dwatch count: %d\n",
> +		seq_printf(m, ", iwatch count: %d, dwatch count: %d",
>   		      cpu_data[n].watch_ireg_count, cpu_data[n].watch_dreg_count);
>   	}
>   
> @@ -104,7 +103,7 @@ static int show_cpuinfo(struct seq_file *m, void *v)
>   	raw_notifier_call_chain(&proc_cpuinfo_chain, 0,
>   				&proc_cpuinfo_notifier_args);
>   
> -	seq_printf(m, "\n");
> +	seq_printf(m, "\n\n");
>   
>   	return 0;
>   }
Best wishes,
--
WangYuli

Attachment: OpenPGP_0xC5DA1F3046F40BEE.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature