Re: [PATCH RFC 02/24] compiler-capability-analysis: Rename __cond_lock() to __cond_acquire()

[Peter Zijlstra]

On Thu, Feb 06, 2025 at 07:09:56PM +0100, Marco Elver wrote:
> Just like the pairing of attribute __acquires() with a matching
> function-like macro __acquire(), the attribute __cond_acquires() should
> have a matching function-like macro __cond_acquire().
> 
> To be consistent, rename __cond_lock() to __cond_acquire().

So I hate this __cond_lock() thing we have with a passion. I think it is
one of the very worst annotations possible since it makes a trainwreck
of the trylock code.

It is a major reason why mutex is not annotated with this nonsense.

Also, I think very dim of sparse in general -- I don't think I've ever
managed to get a useful warning from between all the noise it generates.