Re: [PATCH RFC 11/24] locking/mutex: Support Clang's capability analysis

[Peter Zijlstra]

On Thu, Feb 06, 2025 at 07:10:05PM +0100, Marco Elver wrote:

>  extern int __must_check mutex_lock_interruptible_nested(struct mutex *lock,
> +					unsigned int subclass) __cond_acquires(0, lock);
>  extern int __must_check mutex_lock_killable_nested(struct mutex *lock,
> +					unsigned int subclass) __cond_acquires(0, lock);

> +extern int __must_check mutex_lock_interruptible(struct mutex *lock) __cond_acquires(0, lock);
> +extern int __must_check mutex_lock_killable(struct mutex *lock) __cond_acquires(0, lock);

> +extern int mutex_trylock(struct mutex *lock) __cond_acquires(1, lock);

> +extern int atomic_dec_and_mutex_lock(atomic_t *cnt, struct mutex *lock) __cond_acquires(1, lock);

So this form is *MUCH* saner than what we currently have.

Can we please fix up all the existing __cond_lock() code too?