Re: [PATCH] rust: rbtree: fix overindented list item

From: Alice Ryhl
Date: Fri Feb 07 2025 - 04:35:16 EST


On Fri, Feb 7, 2025 at 12:20 AM Miguel Ojeda <ojeda@xxxxxxxxxx> wrote:
>
> Starting with Rust 1.86.0 (to be released 2025-04-03), Clippy will have
> a new lint, `doc_overindented_list_items` [1], which catches cases of
> overindented list items.
>
> The lint has been added by Yutaro Ohno, based on feedback from the kernel
> [2] on a patch that fixed a similar case -- commit 0c5928deada1 ("rust:
> block: fix formatting in GenDisk doc").
>
> Clippy reports a single case in the kernel, apart from the one already
> fixed in the commit above:
>
> error: doc list item overindented
> --> rust/kernel/rbtree.rs:1152:5
> |
> 1152 | /// null, it is a pointer to the root of the [`RBTree`].
> | ^^^^ help: try using ` ` (2 spaces)
> |
> = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items
> = note: `-D clippy::doc-overindented-list-items` implied by `-D warnings`
> = help: to override `-D warnings` add `#[allow(clippy::doc_overindented_list_items)]`
>
> Thus clean it up.
>
> Cc: Yutaro Ohno <yutaro.ono.418@xxxxxxxxx>
> Cc: <stable@xxxxxxxxxxxxxxx> # Needed in 6.12.y and 6.13.y only (Rust is pinned in older LTSs).
> Fixes: a335e9591404 ("rust: rbtree: add `RBTree::entry`")
> Link: https://github.com/rust-lang/rust-clippy/pull/13711 [1]
> Link: https://github.com/rust-lang/rust-clippy/issues/13601 [2]
> Signed-off-by: Miguel Ojeda <ojeda@xxxxxxxxxx>

Reviewed-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>