Re: [PATCH v2 06/13] iio: adc: ad7606: use gpiod_multi_set_value_cansleep

From: Andy Shevchenko
Date: Fri Feb 07 2025 - 07:14:14 EST


On Fri, Feb 7, 2025 at 12:48 AM David Lechner <dlechner@xxxxxxxxxxxx> wrote:
>
> Reduce verbosity by using gpiod_multi_set_value_cansleep() instead of
> gpiod_set_array_value().
>
> These are not called in an atomic context, so changing to the cansleep
> variant is fine.

...

> if (st->gpio_os) {
> - gpiod_set_array_value(st->gpio_os->ndescs,
> - st->gpio_os->desc, st->gpio_os->info, os);
> + gpiod_multi_set_value_cansleep(st->gpio_os, os);
> }

Now I do not see any justification to leave {}.

--
With Best Regards,
Andy Shevchenko