Re: [PATCH v2] hid: hid-lg-g15: Use standard multicolor LED API

From: Jiri Kosina
Date: Fri Feb 07 2025 - 07:51:42 EST


On Fri, 31 Jan 2025, Kate Hsuan wrote:

> Replace the custom "color" sysfs attribute with the standard multicolor
> LED API.
>
> This also removes the code for the custom "color" sysfs attribute,
> the "color" sysfs attribute was never documented so hopefully, it is not
> used by anyone.
>
> If we get complaints, we can re-add the "color" sysfs attribute as
> a compatibility wrapper setting the subleds intensity.
>
> Signed-off-by: Kate Hsuan <hpa@xxxxxxxxxx>
> ---
> Changes in v2:
> 1. The commit message was revised with the reviewer's suggestions.
> 2. The incorrect parameters for container_of() were fixed.
> 3. The brightness values were converted by led_mc_calc_color_components().

Applied, thank you.

--
Jiri Kosina
SUSE Labs