Re: [PATCH v2 1/3] vfs: add initial support for CONFIG_VFS_DEBUG

[Jan Kara]

On Thu 06-02-25 18:03:05, Mateusz Guzik wrote:
> Small collection of macros taken from mmdebug.h
> 
> Signed-off-by: Mateusz Guzik <mjguzik@xxxxxxxxx>

For start this looks good! Feel free to add:

Reviewed-by: Jan Kara <jack@xxxxxxx>

BTW:

> +/*
> + * TODO: add a proper inode dumping routine, this is a stub to get debug off the ground
> + */
> +static inline void dump_inode(struct inode *inode, const char *reason) {
> +	pr_crit("%s failed for inode %px", reason, inode);
> +}

fs/inode.c:dump_mapping() already has quite a bit of what you'd want here
so just refactoring dump_mapping() so it can be used in the new asserts
would get you 90% there I'd think.

								Honza

-- 
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR