Re: [PATCH v3 4/7] media: rockchip: add a driver for the rockchip camera interface

[kernel test robot]

Hi Michael,

kernel test robot noticed the following build warnings:

[auto build test WARNING on 2014c95afecee3e76ca4a56956a936e23283f05b]

url:    https://github.com/intel-lab-lkp/linux/commits/Michael-Riesch/media-dt-bindings-media-video-interfaces-add-defines-for-sampling-modes/20250206-180041
base:   2014c95afecee3e76ca4a56956a936e23283f05b
patch link:    https://lore.kernel.org/r/20250206-v6-8-topic-rk3568-vicap-v3-4-69d1f19e5c40%40wolfvision.net
patch subject: [PATCH v3 4/7] media: rockchip: add a driver for the rockchip camera interface
config: loongarch-allmodconfig (https://download.01.org/0day-ci/archive/20250207/202502072356.crcHKSbX-lkp@xxxxxxxxx/config)
compiler: loongarch64-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250207/202502072356.crcHKSbX-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502072356.crcHKSbX-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

   drivers/media/platform/rockchip/rkcif/rkcif-capture-dvp.c: In function 'rkcif_dvp_isr':
>> drivers/media/platform/rockchip/rkcif/rkcif-capture-dvp.c:759:32: warning: variable 'ctl' set but not used [-Wunused-but-set-variable]
     759 |         u32 lastline, lastpix, ctl, cif_frmst;
         |                                ^~~


vim +/ctl +759 drivers/media/platform/rockchip/rkcif/rkcif-capture-dvp.c

   752	
   753	irqreturn_t rkcif_dvp_isr(int irq, void *ctx)
   754	{
   755		struct device *dev = ctx;
   756		struct rkcif_device *rkcif = dev_get_drvdata(dev);
   757		struct rkcif_stream *stream;
   758		unsigned int intstat;
 > 759		u32 lastline, lastpix, ctl, cif_frmst;
   760		irqreturn_t ret = IRQ_NONE;
   761	
   762		if (!rkcif->match_data->dvp)
   763			return ret;
   764	
   765		intstat = cif_dvp_read(rkcif, RKCIF_DVP_INTSTAT);
   766		cif_frmst = cif_dvp_read(rkcif, RKCIF_DVP_FRAME_STATUS);
   767		lastline = RKCIF_FETCH_Y_LAST_LINE(
   768			cif_dvp_read(rkcif, RKCIF_DVP_LAST_LINE));
   769		lastpix = RKCIF_FETCH_Y_LAST_LINE(
   770			cif_dvp_read(rkcif, RKCIF_DVP_LAST_PIX));
   771		ctl = cif_dvp_read(rkcif, RKCIF_DVP_CTRL);
   772	
   773		if (intstat & RKCIF_INTSTAT_FRAME_END) {
   774			cif_dvp_write(rkcif, RKCIF_DVP_INTSTAT,
   775				      RKCIF_INTSTAT_FRAME_END_CLR |
   776					      RKCIF_INTSTAT_LINE_END_CLR);
   777	
   778			stream = &rkcif->interfaces[RKCIF_DVP].streams[RKCIF_ID0];
   779	
   780			if (stream->stopping) {
   781				cif_dvp_stop_streaming(stream);
   782				wake_up(&stream->wq_stopped);
   783				return IRQ_HANDLED;
   784			}
   785	
   786			if (lastline != stream->pix.height) {
   787				v4l2_err(&rkcif->v4l2_dev,
   788					 "bad frame, irq:%#x frmst:%#x size:%dx%d\n",
   789					 intstat, cif_frmst, lastpix, lastline);
   790	
   791				cif_dvp_reset_stream(rkcif);
   792			}
   793	
   794			rkcif_stream_pingpong(stream);
   795	
   796			ret = IRQ_HANDLED;
   797		}
   798	
   799		return ret;
   800	}
   801	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki