Re: [PATCH v5 25/40] x86/resctrl: Make prefetch_disable_bits belong to the arch code

[James Morse]

Hi Reinette,

On 23/10/2024 23:53, Reinette Chatre wrote:
> On 10/4/24 11:03 AM, James Morse wrote:
>> prefetch_disable_bits is set by rdtgroup_locksetup_enter() from a
>> value provided by the architecture, but is largely read by other
>> architecture helpers.
>>
>> Instead of exporting this value, make
>> resctrl_arch_get_prefetch_disable_bits() set it so that the other
>> arch-code helpers can use the cached-value.
> 
> The "exporting" term has already caused some confusion. How about:
> 
> Make resctrl_arch_get_prefetch_disable_bits() set prefetch_disable_bits
> so that it can be isolated to arch-code from where the other arch-code
> helpers can use its cached-value.
> 
> (Please feel free to improve.)

I'd cleaned those up - but I'll go with your version as it'll be in the
correct voice.


Thanks,

James