Re: [PATCH 06/11] x86/alternative: Simplify callthunk patching
From: Josh Poimboeuf
Date: Fri Feb 07 2025 - 12:24:07 EST
On Fri, Feb 07, 2025 at 01:15:35PM +0100, Peter Zijlstra wrote:
> +++ b/arch/x86/kernel/alternative.c
> @@ -1697,14 +1697,14 @@ void __init alternative_instructions(voi
> apply_retpolines(__retpoline_sites, __retpoline_sites_end);
> apply_returns(__return_sites, __return_sites_end);
>
> - apply_alternatives(__alt_instructions, __alt_instructions_end);
> -
> /*
> - * Now all calls are established. Apply the call thunks if
> - * required.
> + * Adjust all CALL instructions to point to func()-10, including
> + * those in .altinstr_replacement.
Clarify 10 is hex: "func()-0x10" ?
--
Josh