RE: [PATCH RFC net-next v2 2/3] net: dsa: microchip: Add SGMII port support to KSZ9477 switch

[Tristram.Ha]

> -----Original Message-----
> From: Vladimir Oltean <olteanv@xxxxxxxxx>
> Sent: Friday, February 7, 2025 8:52 AM
> To: Tristram Ha - C24268 <Tristram.Ha@xxxxxxxxxxxxx>
> Cc: Russell King <linux@xxxxxxxxxxxxxxx>; Woojung Huh - C21699
> <Woojung.Huh@xxxxxxxxxxxxx>; Andrew Lunn <andrew@xxxxxxx>; Heiner Kallweit
> <hkallweit1@xxxxxxxxx>; Maxime Chevallier <maxime.chevallier@xxxxxxxxxxx>;
> David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>;
> Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>;
> UNGLinuxDriver <UNGLinuxDriver@xxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH RFC net-next v2 2/3] net: dsa: microchip: Add SGMII port support
> to KSZ9477 switch
> 
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content
> is safe
> 
> On Thu, Feb 06, 2025 at 06:43:15PM -0800, Tristram.Ha@xxxxxxxxxxxxx wrote:
> > From: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>
> >
> > The KSZ9477 DSA driver uses XPCS driver to operate its SGMII port.
> >
> > Signed-off-by: Tristram Ha <tristram.ha@xxxxxxxxxxxxx>
> > ---
> > v2
> >  - update Kconfig to pass compilation test
> >
> >  drivers/net/dsa/microchip/Kconfig | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/net/dsa/microchip/Kconfig b/drivers/net/dsa/microchip/Kconfig
> > index 12a86585a77f..c71d3fd5dfeb 100644
> > --- a/drivers/net/dsa/microchip/Kconfig
> > +++ b/drivers/net/dsa/microchip/Kconfig
> > @@ -6,6 +6,7 @@ menuconfig NET_DSA_MICROCHIP_KSZ_COMMON
> >       select NET_DSA_TAG_NONE
> >       select NET_IEEE8021Q_HELPERS
> >       select DCB
> > +     select PCS_XPCS
> >       help
> >         This driver adds support for Microchip KSZ8, KSZ9 and
> >         LAN937X series switch chips, being KSZ8863/8873,
> > --
> > 2.34.1
> >
> 
> I'm not sure if you split this change intentionally or by mistake, but
> either way, you need to squash this patch into 3/3.

Will update that.